Skip to content
This repository was archived by the owner on Nov 20, 2021. It is now read-only.

plasma 5.23 #24

Open
begonia208 opened this issue Oct 15, 2021 · 15 comments
Open

plasma 5.23 #24

begonia208 opened this issue Oct 15, 2021 · 15 comments

Comments

@begonia208
Copy link

After my system is updated to plasma 5.23 (neon user edition) I can't find the lightly shaders item in the systemsettings/behaviour of desktop/appearance.
It also doesn't work no more...
Just to let you know.
Lighly Shaders is beautiful.

@EvilSquirrelGuy
Copy link

Yeah can confirm this behaviour on Arch as well, most likely due to changes in KWin or kdecoration or some other library changes, the update also broke Parachute KWin script if this is at all relevant

@second2050
Copy link

compile.log
FWIW I uploaded the compilation log from makepkg (the command I used was makepkg -si &> compile.log)

@ZacharyTalis
Copy link

Here's some extra info

I'm attempting to implement a fix in my own ShapeCorners fork. Will letcha folks know if I get something working.

@DarkXero-dev
Copy link

Not building Arch / KDE 5.23.1 ...
https://pastebin.com/xUgTxPni

@gianmarcogg03
Copy link

This fork fixed the issue: https://github.com/sr-tream/LightlyShaders

@begonia208
Copy link
Author

Can you tell where I have to look to customize/activate this fork?
Thank you...

@DarkXero-dev
Copy link

is there a way to PKGBUILD ? Or can I take original's and replace URL in that and build ? I want to add to my own repo for my Distro.

@ZacharyTalis
Copy link

Oh shoot I forgot to mention, my ShapeCorners fork now implements a fix (though this new implementation suffers from the Korners bug).

@ryu-ketsueki
Copy link

Oh shoot I forgot to mention, my ShapeCorners fork now implements a fix (though this new implementation suffers from the Korners bug).

@a-parhom 's fork proposed a fix for the Korners bug but it seems it requires some improvement to be a little more resource friendly. I'm using it on my laptop and so far I didn't get any significant slowdowns

@DarkXero-dev
Copy link

I was finally able to build package and added to repo from SR-Team Fork works well enough for now..

@Luwx
Copy link
Owner

Luwx commented Nov 17, 2021

After taking a look at the changes that were introduced in 5.23, I honestly don't think it's possible to make this effect work like before. KWin no longer exposes a way to paint only the decoration and shadow underneath the window, and this is key to make the effect look good: painting the shadow at the rounded corner.
@a-parhom fork works around this issue by shrinking the shadow so that it fills the rounded section, but at the cost of shadows not looking like they were intended to.
While it's nice to have a more optimized KWin, it's also sad to see these breaking changes and 0 interest of KWin developers to make a native solution to round corners.

@Luwx Luwx added the Important label Nov 17, 2021
@ryu-ketsueki
Copy link

After taking a look at the changes that were introduced in 5.23, I honestly don't think it's possible to make this effect work like before. KWin no longer exposes a way to paint only the decoration and shadow underneath the window, and this is key to make the effect look good: painting the shadow at the rounded corner.
@a-parhom fork works around this issue by shrinking the shadow so that it fills the rounded section, but at the cost of shadows not looking like they were intended to.
While it's nice to have a more optimized KWin, it's also sad to see these breaking changes and 0 interest of KWin developers to make a native solution to round corners.

How about the one on @ZacharyTalis 's ShapeCorners?

@begonia208
Copy link
Author

I found https://github.com/matinlotfali/KDE-Rounded-Corners . It really works great.

@Luwx
Copy link
Owner

Luwx commented Nov 17, 2021

After taking a look at the changes that were introduced in 5.23, I honestly don't think it's possible to make this effect work like before. KWin no longer exposes a way to paint only the decoration and shadow underneath the window, and this is key to make the effect look good: painting the shadow at the rounded corner.
@a-parhom fork works around this issue by shrinking the shadow so that it fills the rounded section, but at the cost of shadows not looking like they were intended to.
While it's nice to have a more optimized KWin, it's also sad to see these breaking changes and 0 interest of KWin developers to make a native solution to round corners.

How about the one on @ZacharyTalis 's ShapeCorners?

The other ones I looked also suffer from the same problem, the missing shadow at the corner, it will look like the korner bug. I'll poke the code a bit more, but I'm afraid a solution to this will be very difficult or extremely hacky.

I'll probably end up archiving this repository.

@ZacharyTalis
Copy link

ZacharyTalis commented Nov 18, 2021

Yep, all the forks I know about suffer from the same Korners issue.

You can mitigate Korners somewhat by using the Inactive Blur wallpaper plugin. Here's what my desktop looks like with the plugin installed:

Tiled KDE desktop featuring a blurred wallpaper.

a-parhom referenced this issue in a-parhom/LightlyShaders Mar 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants