Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify recursive code with Functors v0.5 #1061

Closed
4 tasks
avik-pal opened this issue Nov 8, 2024 · 0 comments · Fixed by #1069
Closed
4 tasks

Simplify recursive code with Functors v0.5 #1061

avik-pal opened this issue Nov 8, 2024 · 0 comments · Fixed by #1069
Labels
enhancement New feature or request

Comments

@avik-pal
Copy link
Member

avik-pal commented Nov 8, 2024

The new release of Functors makes the recursion into nested objects type-stable. So we can rework our recursive_* implementations to directly use Functors.fmap (and even deprecate them in certain cases).

Packages needing updates:

Current Blockers

Downstream updates:
@avik-pal avik-pal added the enhancement New feature or request label Nov 8, 2024
@CarloLucibello CarloLucibello mentioned this issue Nov 9, 2024
Closed
@avik-pal avik-pal linked a pull request Nov 13, 2024 that will close this issue
feat: update to Functors v0.5 #1069
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update to Functors v0.5 LuxDL/Lux.jl
1 participant
@avik-pal