Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

feat: add fallbacks for unknown objects #87

Merged
merged 4 commits into from
Oct 18, 2024
Merged

feat: add fallbacks for unknown objects #87

merged 4 commits into from
Oct 18, 2024

Conversation

avik-pal
Copy link
Member

fixes #82

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 56.00000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 52.40%. Comparing base (0d6c6a8) to head (6c3a4a7).

Files with missing lines Patch % Lines
src/internal.jl 50.00% 9 Missing ⚠️
ext/MLDataDevicesChainRulesCoreExt.jl 60.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (0d6c6a8) and HEAD (6c3a4a7). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (0d6c6a8) HEAD (6c3a4a7)
18 11
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #87       +/-   ##
===========================================
- Coverage   85.39%   52.40%   -32.99%     
===========================================
  Files          19       19               
  Lines         397      416       +19     
===========================================
- Hits          339      218      -121     
- Misses         58      198      +140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal merged commit 17bc9aa into main Oct 18, 2024
25 of 29 checks passed
@avik-pal avik-pal deleted the ap/patch branch October 18, 2024 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_device/get_device_type doesn't support functions/closures
1 participant