Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should rethink is_outlier #61

Open
Shians opened this issue Apr 16, 2018 · 0 comments
Open

We should rethink is_outlier #61

Shians opened this issue Apr 16, 2018 · 0 comments

Comments

@Shians
Copy link
Contributor

Shians commented Apr 16, 2018

So a few people have told me is_outlier is confusing for two reasons:

  1. When we plot it TRUE actually implies a cell a filtered out, people tend to associate TRUE with GOOD and so when they see a low TRUE number they panic for a second. Maybe we should just rename it "not_outlier"

  2. The is_outlier column is currently encoded as a factor, I know the reason is probably because that's how you get it to show up in the upper triangle of the ggpairs, but it makes a lot more sense to just encode it as a logical and create a temporary object with conversion to factors just before we call ggpairs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant