Unable to upload images: "The total chunks must be an integer."

[sn-dirk]

Lychee version

v6.2.0

Which PHP version are you using?

PHP 8.3

Detailed description of the problem

After upgrading from Lychee 4 uploading any images does not work, the error message "The total chunks must be an integer." is instantly display.

Checking with the developer tools in the network tab I see that the value of "total_chunks" that is sent to the server is set to "Infinity".

Steps to reproduce the issue

No response

Diagnostics [REQUIRED]

Diagnostics
-----------
Warning: You may experience problems when uploading a photo of large size. Take a look in the FAQ for details.
Warning: You may experience problems when uploading a photo of large size. Take a look in the FAQ for details.
Warning: You may experience problems when uploading a photo of large size or handling many/large albums. Take a look in the FAQ for details.
Warning: Pictures that are rotated lose their metadata! Please install Imagick to avoid that.
Warning: zend.assertions is enabled although Lychee is not in debug mode. Outside of debugging, code generation for assertions is recommended to be disabled for efficiency reasons
Warning: Default timezone not properly set; you might experience strange results when importing photos without explicit EXIF timezone
Info: Found 437 small that could be generated.
     You can use `php artisan lychee:generate_thumbs small 437` to generate them.
Info: Found 419 small2x that could be generated.
     You can use `php artisan lychee:generate_thumbs small2x 419` to generate them.
Info: Found 260 medium that could be generated.
     You can use `php artisan lychee:generate_thumbs medium 260` to generate them.
Info: Found 54 medium2x that could be generated.
     You can use `php artisan lychee:generate_thumbs medium2x 54` to generate them.
Info: Found 673 placeholders that could be generated.
     You can use `php artisan lychee:generate_thumbs placeholder 673` to generate them.
Info: Found 2051 small images without filesizes.
     You can use `php artisan lychee:variant_filesize 2051` to compute them.
Info: Have you considered supporting Lychee? :)

System Information
------------------
Lychee Version (release):                  6.2.0
DB Version:                                6.2.0

composer install:                          --no-dev
APP_ENV:                                   production
APP_DEBUG:                                 false
APP_URL:                                   set
APP_DIR:                                   default
LOG_VIEWER_ENABLED:                        true
VUEJS_ENABLED:                             true
PHOTO_PIPES:                               true

System:                                    Linux
PHP Version:                               8.3.16
PHP User agent:                            Lychee/4 (https://lycheeorg.github.io/)
Timezone:                                  UTC
Max uploaded file size:                    2M
Max post size:                             8M
Chunk size:                                2.00 MB
Max execution time:                        30
MySQL Version:                             10.11.7-MariaDB-log

exec() Available:                          yes
Imagick Available:                         -
Imagick Enabled:                           1
Imagick Version:                           -
GD Version:                                2.3.0
Number of foreign key:                     12 found.

Config Information
------------------
version:                                   060200
check_for_updates:                         0
sorting_photos_col:                        created_at
sorting_photos_order:                      DESC
sorting_albums_col:                        created_at
sorting_albums_order:                      DESC
imagick:                                   1
skip_duplicates:                           0
small_max_width:                           0
small_max_height:                          360
medium_max_width:                          1920
medium_max_height:                         1080
lang:                                      en
image_overlay_type:                        desc
default_license:                           reserved
compression_quality:                       90
grants_full_photo_access:                  1
delete_imported:                           0
mod_frame_enabled:                         1
mod_frame_refresh:                         30
thumb_2x:                                  1
small_2x:                                  1
medium_2x:                                 1
landing_page_enable:                       0
force_migration_in_production:             0
search_public:                             0
hide_version_number:                       0
SL_enable:                                 0
SL_for_admin:                              0
recent_age:                                1
grants_download:                           0
photos_wraparound:                         1
map_display:                               0
zip64:                                     1
map_display_public:                        0
map_provider:                              Wikimedia
force_32bit_ids:                           0
map_include_subalbums:                     0
update_check_every_days:                   3
has_exiftool:                              0
share_button_visible:                      0
import_via_symlink:                        0
has_ffmpeg:                                0
location_decoding:                         0
location_decoding_timeout:                 30
location_show:                             0
location_show_public:                      0
rss_enable:                                0
rss_recent_days:                           7
rss_max_items:                             100
prefer_available_xmp_metadata:             0
editor_enabled:                            1
lossless_optimization:                     0
swipe_tolerance_x:                         150
swipe_tolerance_y:                         250
local_takestamp_video_formats:             .avi|.mov
log_max_num_line:                          1000
unlock_password_photos_with_url_param:     0
nsfw_visible:                              1
nsfw_blur:                                 0
nsfw_warning:                              0
nsfw_warning_admin:                        0
nsfw_banner_override:
map_display_direction:                     1
album_subtitle_type:                       oldstyle
upload_processing_limit:                   4
new_photos_notification:                   0
legacy_id_redirection:                     1
zip_deflate_level:                         6
default_album_protection:                  1
album_decoration:                          layers
album_decoration_orientation:              row
allow_username_change:                     1
auto_fix_orientation:                      1
use_job_queues:                            0
random_album_id:                           starred
use_last_modified_date_when_no_exif_date:  0
layout:                                    justified
date_format_photo_thumb:                   M j, Y, g:i:s A e
date_format_photo_overlay:                 M j, Y, g:i:s A e
date_format_sidebar_uploaded:              M j, Y, g:i:s A e
date_format_sidebar_taken_at:              M j, Y, g:i:s A e
date_format_hero_min_max:                  F Y
date_format_hero_created_at:               M j, Y, g:i:s A T
date_format_album_thumb:                   M Y
upload_chunk_size:                         0
nsfw_banner_blur_backdrop:                 0
search_pagination_limit:                   1000
search_minimum_length_required:            4
photo_layout_justified_row_height:         320
photo_layout_masonry_column_width:         300
photo_layout_grid_column_width:            250
photo_layout_square_column_width:          200
photo_layout_gap:                          12
display_thumb_album_overlay:               always
display_thumb_photo_overlay:               hover
default_album_thumb_aspect_ratio:          1/1
use_album_compact_header:                  0
login_button_position:                     left
back_button_enabled:                       0
back_button_text:                          Return to Home
current_job_processing_visible:            1
SA_random_thumbs:                          0
job_processing_queue_visible:              1
login_required:                            0
enable_unsorted:                           1
enable_starred:                            1
enable_recent:                             1
enable_on_this_day:                        1
login_required_root_only:                  1
dark_mode_enabled:                         1
low_quality_image_placeholder:             1
show_keybinding_help_popup:                1
show_keybinding_help_button:               1
disable_se_call_for_actions:               0
enable_se_preview:                         0
slideshow_timeout:                         5
keep_original_untouched:                   1
timeline_photos_enabled:                   1
timeline_photos_public:                    0
timeline_photos_granularity:               day
timeline_photos_order:                     taken_at
timeline_photos_layout:                    square
timeline_photos_pagination_limit:          200
timeline_albums_enabled:                   1
timeline_albums_public:                    0
timeline_albums_granularity:               year
timeline_left_border_enabled:              1
timeline_photo_date_format_year:           Y
timeline_photo_date_format_month:          M Y
timeline_photo_date_format_day:            j M Y
timeline_photo_date_format_hour:           g:i
timeline_album_date_format_year:           Y
timeline_album_date_format_month:          M Y
timeline_album_date_format_day:            j M
hide_nsfw_in_smart_albums:                 1
hide_nsfw_in_frame:                        1
hide_nsfw_in_map:                          1
hide_nsfw_in_search:                       1
search_photos_layout:                      square
hide_nsfw_in_rss:                          1
hide_nsfw_in_timeline:                     1
number_albums_per_row_mobile:              3
X-Powered-By: PHP/8.3.16
Content-type: text/html; charset=UTF-8

Browser & System [REQUIRED]

Google Chrome on Windows 11.

Please confirm (incomplete submissions will not be addressed)

• I have provided easy and step-by-step instructions to reproduce the bug.
• I understand my bug report will be removed if I haven't met the criteria above.

[ildyria]

Can you:

1. press F12, go to the network tab
2. refresh the page and look for the request to Gallery::getUploadLimits and tell me what is the response for that request?

[sn-dirk]

Response: {"upload_processing_limit":4,"upload_chunk_size":0}

[ildyria]

	public static function getUploadLimit(): int
	{
		$size = Configs::getValueAsInt('upload_chunk_size');
		if ($size === 0) {
			try {
				$size = (int) min(
					Helpers::convertSize(ini_get('upload_max_filesize')),
					Helpers::convertSize(ini_get('post_max_size')),
					Helpers::convertSize(ini_get('memory_limit')) / 10
				);
			} catch (InfoException $e) {
				return 1024 * 1024;
			}
		}

		return $size;
	}

My guess is that you are providing a string in that upload_chunk_size config.
Use a number instead.

[ildyria]

hummm that does not make sense though. Your config says:

Chunk size:                                2.00 MB

Which correspond to that code:

$data[] = Diagnostics::line('Chunk size:', Helpers::getSymbolByQuantity(UploadConfig::getUploadLimit()));

with

	public function getSymbolByQuantity(float $bytes): string
	{
		$symbols = [
			'B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB', 'ZB', 'YB',
		];
		$exp = intval(floor(log($bytes) / log(1024.0)));

		if ($exp >= sizeof($symbols)) {
			// @codeCoverageIgnoreStart
			// if the number is too large, we fall back to the largest available symbol
			$exp = sizeof($symbols) - 1;
			// @codeCoverageIgnoreEnd
		}

		return sprintf('%.2f %s', ($bytes / pow(1024, $exp)), $symbols[$exp]);
	}

[ildyria]

@sn-dirk can you replace the file: app/Http/Resources/GalleryConfigs/UploadConfig.php with the following?
https://gist.github.com/ildyria/722affa443e8c2bbc5c463f0e3e0101e
I expect you get an error 500 but I am curious of the response. (you may need to set your APP_DEBUG=true in your .env

[sn-dirk]

Is the value calculated here?

Lychee/resources/js/components/forms/upload/UploadingLine.vue

Line 49 in 1d459f0

total_chunks: Math.ceil(size.value / props.chunkSize),

const meta = ref({
	file_name: file.value.name,
	extension: null,
	uuid_name: null,
	stage: "uploading",
	chunk_number: 0,
	total_chunks: Math.ceil(size.value / props.chunkSize),
} as App.Http.Resources.Editable.UploadMetaResource);

So, props.chunkSize ends up being 0, therefore sending Infinity to the server (and getting the "must be an integer" message)?

[ildyria]

yes. that is the result of having chunkSize = 0.

[ildyria]

@sn-dirk can you check your config value for "Size of chunks when uploading in bytes: 0 is auto"
Or the key: upload_chunk_size

Nevermind, I got it from your diagnostic, it is set to 0.

[sn-dirk]

Manually setting a size (I've used 1048576) indeed fixes the issue and I can now upload. Thanks for your help!

I was under the impression that 0 is valid, because of the description in the database: "Size of chunks when uploading in bytes: 0 is auto"

[ildyria]

0 should be a valid value. The code should also support it. So its really weird