Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support user-supplied requests.Session object for HTTP/S requests #85

Open
chuckwondo opened this issue Mar 4, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@chuckwondo
Copy link
Contributor

The requests library is used for HTTP/S requests. Default session objects are used for every request (implicitly), which not only does not allow use of custom sessions, but also may negatively impact performance to some extent because there are places where multiple requests might occur, but no session is shared across the requests, thus connection pooling is not leveraged.

Support should be added for supplying a requests_session kwarg to the MAAP initializer so that the supplied session can be used for all requests. By exposing such functionality, a user may also configure Retry capabilities. Further, we can supply sensible default retry capabilities so users don't have to configure retries if the defaults suffice.

@chuckwondo chuckwondo added the enhancement New feature or request label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant