Modify TFocean vertical interpolation for depths outside of data range #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ISMIP6 code for interpolating TF vertically does not give correct values for depths below the deepest data z-level. This commit handles that case by using the deepest TF value corrected by the freezing temperature depth-dependence. It also handles the less critical situation of depths above the shallowest data level by using the shallowest value unmodified.
matthewhoffman
force-pushed
the
matthewhoffman/mali/tf-vert-interp-fix
branch
from
84d7a06 to
e2055b7
Compare
xylar
approved these changes
Jan 6, 2025
components/mpas-albany-landice/src/mode_forward/mpas_li_iceshelf_melt.F
Outdated
Show resolved
Hide resolved
Co-authored-by: Xylar Asay-Davis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ISMIP6 code for interpolating TF vertically does not give correct values for depths below the deepest data z-level. This commit handles that case by using the deepest TF value corrected by the freezing temperature depth-dependence. It also handles the less critical situation of depths above the shallowest data level by using the shallowest value unmodified.