Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDF_UINT8 does not exist #275

Closed
subagonsouth opened this issue Aug 29, 2024 · 1 comment · Fixed by #285
Closed

CDF_UINT8 does not exist #275

subagonsouth opened this issue Aug 29, 2024 · 1 comment · Fixed by #285
Assignees

Comments

@subagonsouth
Copy link

https://github.com/MAVENSDC/cdflib/blob/main/cdflib/xarray/xarray_to_cdf.py#L169
CDF_UINT8 does not exist. This should be cast to a int64 and then use CDF_INT8?

@bryan-harter bryan-harter moved this from To triage to Backlog in cdflib development Dec 23, 2024
@bryan-harter bryan-harter moved this from Backlog to Ready in cdflib development Jan 10, 2025
@bryan-harter bryan-harter moved this from Ready to In progress in cdflib development Jan 10, 2025
@bryan-harter
Copy link
Member

If we're being super strict about it, then we'll just reject np.uint64 altogether and display an error that we can't handle that data type. I hesitate to convert anything automatically that has the potential to significantly alter the data

@bryan-harter bryan-harter self-assigned this Jan 10, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in cdflib development Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants