Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDF_TIME_TT2000 should not include leap seconds #283

Open
maxinelasp opened this issue Jan 3, 2025 · 0 comments
Open

CDF_TIME_TT2000 should not include leap seconds #283

maxinelasp opened this issue Jan 3, 2025 · 0 comments

Comments

@maxinelasp
Copy link
Contributor

The documentation in cdflib.epochs.py states that CDF_TIME_TT2000 includes leap seconds. However, per this document, CDF_TIME_TT2000 is in TT format and therefore does not add leap seconds.

From SDFC: "Given a current list of leap seconds, conversion between TT and UTC is straightforward (TT = TAI + 32.184s; TT = UTC + deltaAT + 32.184s, where deltaAT is the sum of the leap seconds since 1960; for example, for 2009, deltaAT = 34s). "

Per Wikipedia and NAIF, TT is based on TAI which does not add leap seconds.

Therefore, I believe this documentation is wrong. However, from looking through the code, in particular breakdown_tt2000 which converts TT2000 into UTC and correctly includes a leap second addition, this is only an issue in the documentation and not in the code itself.

If this is an issue, I'm happy to open a PR to correct it - just wanted to check in and see if I am right first.

@bryan-harter bryan-harter moved this from To triage to Backlog in cdflib development Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant