Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Validations are missing on the sign in page #113

Closed
Niharika0104 opened this issue May 14, 2024 · 3 comments
Closed

feat: Validations are missing on the sign in page #113

Niharika0104 opened this issue May 14, 2024 · 3 comments
Assignees
Labels
gssoc Under GirlScript Summer of code GSSoC'24 Under GirlScript Summer of code level2 medium

Comments

@Niharika0104
Copy link
Contributor

Niharika0104 commented May 14, 2024

Is your feature request related to a problem? Please describe.
I see that validations are missing on the sign in page.Adding validations will make it ui friendly and will not cause unneccessary call to the database as well will only call the method if the data entered in the form is valid.
Currently the sign in button looks like the button is disabled but it's always good to have the validation messages.

Describe the solution you'd like
I will use react-toastify library to show the validation errors.

Describe alternatives you've considered
I can also just provide the error message in the text format but ,the former method is more modern and ui friendly

@MAVRICK-1
Copy link
Owner

go ahead but follow the css hierarchy

@MAVRICK-1 MAVRICK-1 added GSSoC'24 Under GirlScript Summer of code level2 medium gssoc Under GirlScript Summer of code labels May 14, 2024
@Niharika0104
Copy link
Contributor Author

@MAVRICK-1 may I know why is this issue closed

@MAVRICK-1
Copy link
Owner

@Niharika0104 #44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Under GirlScript Summer of code GSSoC'24 Under GirlScript Summer of code level2 medium
Projects
None yet
Development

No branches or pull requests

2 participants