Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP passed to API is blank #9

Open
spathizilla opened this issue Jun 10, 2013 · 0 comments
Open

IP passed to API is blank #9

spathizilla opened this issue Jun 10, 2013 · 0 comments

Comments

@spathizilla
Copy link

In LoginEventHandler.java on line 46, the ip address gathered there is always null.

URLEncoder.encode(String.valueOf(pc.getAddress().getHostName()), "UTF-8");

This becomes a major issue when someone has an ip lock on their Minecraft username as the mcbans API thinks the ip address is incorrect. (This is a major issue for me since I do have an ip lock - which seems to never remove)

Perhaps use getHostString() instead of getHostName()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant