Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ci, bump up python to 3.10+ #59

Merged
merged 2 commits into from
Jul 22, 2024
Merged

fix ci, bump up python to 3.10+ #59

merged 2 commits into from
Jul 22, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jul 22, 2024

Fixes #56

Changes made in this Pull Request:

  • CI now no longer uses auto python range generation
  • Python 3.9 has been dropped
  • MDAnalysis 2.0.0 has been dropped
  • meta.yaml and build.sh files seemed unused and redundant so they have been removed

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.91%. Comparing base (7c5ae8d) to head (2d94b0a).
Report is 1 commits behind head on main.

Additional details and impacted files

orbeckst
orbeckst approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the updates and adjustments! lgtm

@orbeckst orbeckst self-assigned this Jul 22, 2024
@orbeckst orbeckst merged commit ae5148d into main Jul 22, 2024
17 checks passed
@orbeckst orbeckst deleted the fix-ci branch July 22, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbeckst orbeckst orbeckst approved these changes

@fiona-naughton fiona-naughton Awaiting requested review from fiona-naughton

@lilyminium lilyminium Awaiting requested review from lilyminium

Assignees

@orbeckst orbeckst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI fails for Python 3.9
2 participants
@IAlibay @orbeckst