Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite AnalysisBase to be compatible with pmda.parallel.AnalysisBase #2542

Closed
orbeckst opened this issue Feb 19, 2020 · 6 comments
Closed

Comments

@orbeckst
Copy link
Member

Expected behavior

MDAnalysis and pmda share code and it is easy to parallelize existing analysis; we don't maintain duplicate code. For instance, I should be able to take a _single_frame() method for MDAnalysis directly in pmda.

Actual behavior

MDAnalysis.analysis.base.AnalysisBase and pmda.parallel.AnalysisBase are different because the serial version can easily share data via the class while the parallel version must have _single_frame() return the results for accumulation. The parallel version has _reduce to handle accumulation in a parallelizable fashion.

Comments

pmda is only one way to parallelize trajectory analysis. However, my understanding is that as soon as one wants to distribute work over processes that cannot communicate by shared memory one needs to change the way in which AnalysisBase works. Therefore, I think that adapting the pmda model is a step in the right direction.

@IAlibay
Copy link
Member

IAlibay commented Apr 6, 2021

Is this still feasible for 2.0?

How is this affected by the proposed changes for mda_cli? Pinging @PicoCentauri here.

@IAlibay IAlibay assigned orbeckst and IAlibay and unassigned orbeckst and IAlibay Apr 6, 2021
@orbeckst
Copy link
Member Author

orbeckst commented Apr 6, 2021

Not feasible for 2.0

@IAlibay
Copy link
Member

IAlibay commented Apr 6, 2021

@orbeckst shall we move this to 2.1 or do we think it's now become a 3.0 target?

@orbeckst
Copy link
Member Author

orbeckst commented Apr 6, 2021 via email

@IAlibay IAlibay modified the milestones: 2.0, 3.0 Apr 6, 2021
@IAlibay
Copy link
Member

IAlibay commented Oct 7, 2023

Looks to me like we're going a different direction here -- closing.

@IAlibay IAlibay closed this as not planned Won't fix, can't repro, duplicate, stale Oct 7, 2023
@RMeli
Copy link
Member

RMeli commented Oct 7, 2023

Linking #4158 for record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants