Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] change labeler action to NOT sync labels #4840

Open
orbeckst opened this issue Dec 17, 2024 · 6 comments · May be fixed by #4895
Open

[CI] change labeler action to NOT sync labels #4840

orbeckst opened this issue Dec 17, 2024 · 6 comments · May be fixed by #4895
Assignees
Labels
Continuous Integration decision needed requires input from developers before moving further

Comments

@orbeckst
Copy link
Member

The label sync workflow removes manually added labels via

sync-labels: true # remove labels if file not modified anymore

Personally I'd prefer if labels that were manually assigned stayed in place and the sync option were turned off.

@AirBwender
Copy link

AirBwender commented Dec 20, 2024

The sync-labels option in .github/workflows/labels.yaml is currently set to true, which removes manually added labels that aren't in labels.yaml, correct? Would it be okay if I change this to false, or do you suggest a different approach? I’d prefer to keep manually assigned labels intact, but should we consider a priority system for which manual labels to keep and which to remove, or should we remove them entirely?

@orbeckst orbeckst added the decision needed requires input from developers before moving further label Dec 20, 2024
@orbeckst
Copy link
Member Author

Thanks for offering to help! However, we first need to figure out if the developer team wants to make this change. I should have made that clearer when I raised the issue.

@orbeckst orbeckst self-assigned this Dec 20, 2024
@AirBwender
Copy link

Ah okay, no worries.

@orbeckst
Copy link
Member Author

orbeckst commented Jan 7, 2025

@MDAnalysis/coredevs can we please switch off the GH sync-labels workflow?

If you want to discuss, please add comments. Otherwise 👍 or 👎 on the top of the issue over the next week. Thanks.

@orbeckst
Copy link
Member Author

Unless there are any final objections, I'll change the behavior by Monday Jan 20.

orbeckst added a commit that referenced this issue Jan 17, 2025
@orbeckst orbeckst linked a pull request Jan 17, 2025 that will close this issue
5 tasks
@orbeckst
Copy link
Member Author

(I put up the PR; if people object I can close it together with the issue.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Continuous Integration decision needed requires input from developers before moving further
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants