Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to LGPLv2.1+ #41

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Switch to LGPLv2.1+ #41

merged 2 commits into from
Nov 25, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Nov 22, 2024

Whilst the original code contribution has been accepted as LGPLv2.1+, we have to relicense this MDAKit.

  • We have a contribution from @rodpollet which does not have a relicensing agreement, which we will need before merging this PR.

PR Checklist

  • CHANGELOG updated?

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.40%. Comparing base (54e9409) to head (ab0205e).
Report is 1 commits behind head on main.

Additional details and impacted files
---- 🚨 Try these New Features:

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to the relicensing under LGPLv2.1+.

I'll try to contact @rodpollet . I am blocking until we have their agreement.

@IAlibay
Copy link
Member Author

IAlibay commented Nov 22, 2024

@orbeckst I've just emailed @rodpollet

Also I'm going to ignore the windows failures for now - I believe these will fix themselves once we release a new version of MDAnalysis.

@IAlibay
Copy link
Member Author

IAlibay commented Nov 22, 2024

@fiona-naughton @ianmkenney if you can approve the relicense this would be great.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block until we have @rodpollet 's agreement to the license change.

@fiona-naughton
Copy link
Contributor

Just noticed that the license is also mentioned in README.md under the "Copyright" section, so it also needs to be updated there (pathsimanaysis and mdahole2 both also have the old license info in the README, I can make a quick some PRs for them)

@orbeckst
Copy link
Member

orbeckst commented Nov 23, 2024 via email

@IAlibay
Copy link
Member Author

IAlibay commented Nov 25, 2024

Just noticed that the license is also mentioned in README.md under the "Copyright" section, so it also needs to be updated there (pathsimanaysis and mdahole2 both also have the old license info in the README, I can make a quick some PRs for them)

This is done thanks.

@IAlibay
Copy link
Member Author

IAlibay commented Nov 25, 2024

@orbeckst we have the agreement, are you ok to approve?

@orbeckst orbeckst self-assigned this Nov 25, 2024
@orbeckst orbeckst merged commit 8076ffe into main Nov 25, 2024
18 of 20 checks passed
@orbeckst orbeckst deleted the lgpl branch November 25, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants