miscellaneous comments #3
Closed
JisuJung928
started this conversation in
General
Replies: 1 comment
-
Overhead from calling the function is good point that we need to check. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
SIMPLE-NN_v2/test_sf/test_sf.py
Line 88 in 14b4c14
For readability, please define angular ACSF including 2**(1-zeta) as it is written (J. Chem. Phys. 134, 074106 (2011)).
SIMPLE-NN_v2/test_sf/test_sf.py
Line 18 in 14b4c14
How about replacing all functions of
math
withnumpy
fordtype
management and a faster matrix calculation someday?SIMPLE-NN_v2/symmetry_function/__init__.py
Line 103 in fde2d08
How about dealing with
res
variable in inline for avoiding overhead from calling the function in python?Beta Was this translation helpful? Give feedback.
All reactions