Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO list #86

Open
13 of 19 tasks
YutackPark opened this issue Sep 8, 2024 · 3 comments
Open
13 of 19 tasks

TODO list #86

YutackPark opened this issue Sep 8, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers

Comments

@YutackPark
Copy link
Member

YutackPark commented Sep 8, 2024

TODO list

----------- on 'refactor' branch && v0.10.0 --------------

------------ Urgent -----------------

----------- Future -------------

  • on-the-fly graph build training routine # experimentally implemented in ase_db branch
  • Accelerated training with graph padding and torch.compile
  • Modal select inputs for LAMMPS
  • tag-wise weights (from sturcture_list or more) and logging
  • Remove redundant keys in dataload.py (node_features, pos, cell, cell_shift, num_atoms(?), per_atom_energy)
@YutackPark YutackPark added the enhancement New feature or request label Sep 8, 2024
@YutackPark YutackPark self-assigned this Sep 8, 2024
@thangckt
Copy link
Contributor

thangckt commented Sep 12, 2024

I suggest refactor the code to process dataset. It is too complicate, hard to read, making somebody lazy to contribute

@thangckt
Copy link
Contributor

hi @YutackPark
Are you consider to pure pyproject.toml ? I see many other project do not need setup.* files.
I also recommand to use ruff as both linter & formatter, it demonstrates better performance over other ones.

@YutackPark
Copy link
Member Author

Hi @thangckt

Are you consider to pure pyproject.toml ? I see many other project do not need setup.* files.
Absolutely yes. But I left setup.py for editable mode when I first wrote project.toml. Because I wasn't able to install SevenNet with pip -e.

I also recommand to use ruff as both linter & formatter, it demonstrates better performance over other ones.
Thanks for the recommendation. Maybe I could migrate to ruff with #98, and before github actions.

@YutackPark YutackPark added documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Oct 9, 2024
@YutackPark YutackPark pinned this issue Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants