Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce BIDS Derivatives-compatible ICA inputs #17

Open
tsalo opened this issue Oct 26, 2020 · 4 comments
Open

Enforce BIDS Derivatives-compatible ICA inputs #17

tsalo opened this issue Oct 26, 2020 · 4 comments

Comments

@tsalo
Copy link
Member

tsalo commented Oct 26, 2020

We should restructure the ICA outputs that ICA-AROMA ingests to be BIDS Derivatives-compatible. In order to maintain support for MELODIC, I think we need a new function that converts MELODIC outputs to a BIDS Derivatives outputs. The main ICA-AROMA functions would then just use BIDS Derivatives outputs.

@tsalo tsalo changed the title Use BIDS Derivatives-compatible ICA outputs Use BIDS Derivatives-compatible ICA inputs Nov 3, 2020
@tsalo tsalo changed the title Use BIDS Derivatives-compatible ICA inputs Accept BIDS Derivatives-compatible ICA inputs Nov 7, 2020
@eurunuela eurunuela transferred this issue from Brainhack-Donostia/ica-aroma-org Nov 11, 2020
@eurunuela eurunuela added the Enhancement New feature or request label Nov 11, 2020
@oesteban
Copy link

Totally in favor of this.

I think we need a new function that converts MELODIC outputs to a BIDS Derivatives outputs. The main ICA-AROMA functions would then just use BIDS Derivatives outputs.

Yes, but let's not make that function part of this issue and give it a super-low priority.

@oesteban
Copy link

In other words, I would replace "Accept" with "Enforce" in the title of this issue, and assume that the input components are BIDS compliant.

@tsalo
Copy link
Member Author

tsalo commented Nov 11, 2020

That works for me. I think a MELODIC-to-BIDS Derivatives function should go in a separate repository anyway. I would just prefer to have it as a Python function if at all possible, so that AROMA users won't need to get nipype working to use it.

@tsalo tsalo changed the title Accept BIDS Derivatives-compatible ICA inputs Enforce BIDS Derivatives-compatible ICA inputs Nov 11, 2020
@oesteban
Copy link

I would just prefer to have it as a Python function if at all possible

Makes sense. If this project progresses quickly, that could be a nice feature to have 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

3 participants