Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding landing gear mass models #107

Closed
wants to merge 9 commits into from

Conversation

ngomezve
Copy link
Contributor

This PR introduces new landing gear mass models based on historical correlations. In the future, physics-based models could be included as well. The following changes are made:

  • Two landing gear models are supported: the previous constant mass fractions and a model based on historical data, which incorporates dependencies on landing gear length and design.
  • The landing gear parameters are stored in a new object in ac. The related parg parameters are eliminated.
  • The balance() and mission!() functions now take in the ac object directly instead of the par arrays; these are then unpacked inside the functions. This makes the syntax more robust to changes in data storage.
  • Documentation and tests for the landing gear models.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 73.08%. Comparing base (3702aba) to head (10357e0).
Report is 221 commits behind head on main.

Files with missing lines Patch % Lines
src/IO/read_input.jl 60.00% 8 Missing ⚠️
src/IO/save_model.jl 0.00% 7 Missing ⚠️
src/IO/outputs.jl 66.66% 2 Missing ⚠️
src/misc/aircraft.jl 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main     #107       +/-   ##
==========================================
+ Coverage   5.45%   73.08%   +67.62%     
==========================================
  Files         79       82        +3     
  Lines      13753    13582      -171     
==========================================
+ Hits         750     9926     +9176     
+ Misses     13003     3656     -9347     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngomezve
Copy link
Contributor Author

Superseded by PR #128

@ngomezve ngomezve closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant