Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reparse logs and pre-parse full log #19

Open
equationcrunchor opened this issue Jan 28, 2021 · 2 comments
Open

Don't reparse logs and pre-parse full log #19

equationcrunchor opened this issue Jan 28, 2021 · 2 comments
Assignees

Comments

@equationcrunchor
Copy link

equationcrunchor commented Jan 28, 2021

Code written; needs tests.

@rhuffy
Copy link
Member

rhuffy commented Feb 11, 2021

This involves two steps.

  1. On the cloud functions side, after a new .csv file is created and saved to Cloud Storage, save the filename to Firestore.

  2. On the frontend, before calling the cloud function, check to see if there already exists a filename on Firestore for this file with this combination of columns and log rate. If yes, get a download link for that file. Else, proceed as normal and call the cloud function.

@rhuffy
Copy link
Member

rhuffy commented Feb 11, 2021

For log file cache keys, a good format would be <Column A>,<Column B>,<Column C>,<Log Rate>. Column names should be alphabetized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants