Smaller fixes (#76)

* Removed unnecessary print-statement * Added kwargs to BaseDetector.fit()
ML-KULeuven · Jan 17, 2025 · c373466 · c373466
1 parent 3778b9c
commit c373466
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/dtaianomaly/anomaly_detection/BaseDetector.py b/dtaianomaly/anomaly_detection/BaseDetector.py
@@ -46,7 +46,7 @@ def __init__(self, supervision: Supervision):
         self.supervision = supervision
 
     @abc.abstractmethod
-    def fit(self, X: np.ndarray, y: Optional[np.ndarray] = None) -> 'BaseDetector':
+    def fit(self, X: np.ndarray, y: Optional[np.ndarray] = None, **kwargs) -> 'BaseDetector':
         """
         Abstract method, fit this detector to the given data.
 

diff --git a/dtaianomaly/anomaly_detection/MedianMethod.py b/dtaianomaly/anomaly_detection/MedianMethod.py
@@ -67,7 +67,7 @@ def __init__(self, neighborhood_size_before: int, neighborhood_size_after: Optio
         self.neighborhood_size_before = neighborhood_size_before
         self.neighborhood_size_after = neighborhood_size_after
 
-    def fit(self, X: np.ndarray, y: Optional[np.ndarray] = None) -> 'BaseDetector':
+    def fit(self, X: np.ndarray, y: Optional[np.ndarray] = None, **kwargs) -> 'BaseDetector':
         return self  # No fitting is required.
 
     def decision_function(self, X: np.ndarray) -> np.ndarray:

diff --git a/dtaianomaly/anomaly_detection/baselines/baselines.py b/dtaianomaly/anomaly_detection/baselines/baselines.py
@@ -15,7 +15,7 @@ class AlwaysNormal(BaseDetector):
     def __init__(self):
         super().__init__(Supervision.UNSUPERVISED)
 
-    def fit(self, X: np.ndarray, y: Optional[np.ndarray] = None) -> 'AlwaysNormal':
+    def fit(self, X: np.ndarray, y: Optional[np.ndarray] = None, **kwargs) -> 'AlwaysNormal':
         """
         Simply return this detector, because no fitting is required.
 
@@ -67,7 +67,7 @@ class AlwaysAnomalous(BaseDetector):
     def __init__(self):
         super().__init__(Supervision.UNSUPERVISED)
 
-    def fit(self, X: np.ndarray, y: Optional[np.ndarray] = None) -> 'AlwaysAnomalous':
+    def fit(self, X: np.ndarray, y: Optional[np.ndarray] = None, **kwargs) -> 'AlwaysAnomalous':
         """
         Simply return this detector, because no fitting is required.
 
@@ -126,7 +126,7 @@ def __init__(self, seed: Optional[int] = None):
         super().__init__(Supervision.UNSUPERVISED)
         self.seed = seed
 
-    def fit(self, X: np.ndarray, y: Optional[np.ndarray] = None) -> 'RandomDetector':
+    def fit(self, X: np.ndarray, y: Optional[np.ndarray] = None, **kwargs) -> 'RandomDetector':
         """
         Simply return this detector, because no fitting is required.
 

diff --git a/dtaianomaly/anomaly_detection/windowing_utils.py b/dtaianomaly/anomaly_detection/windowing_utils.py
@@ -192,7 +192,6 @@ def compute_window_size(
 
     # Use the fft to compute a window size
     elif window_size == 'fft':
-        print('REACHED')
         window_size_ = _dominant_fourier_frequency(X, lower_bound=lower_bound, upper_bound=upper_bound)
 
     # Use the acf to compute a window size