fix(idm): reset auxvar 2d arrray in array input loader each period (#1548)

* reset auxvar 2d arrray in array input loader each period

* cleanup

* update the release notes

---------

Co-authored-by: mjreno <[email protected]>

Author: mjreno

doc/ReleaseNotes/develop.tex

@@ -22,6 +22,7 @@
 	\begin{itemize}
 		\item Improve error message if the size of data read from a binary array file is inconsistent with READARRAY control line and variable description keywords.
 		\item The area calculation for cells in the DISV package was inaccurate for some cases with very large cell vertex coordinates.  The area calculation was improved by using transformed cell vertex coordinates prior to making the area calculation.
+		\item Auxiliary variables in RCH and EVT Array-Based input packages corrected to reset to zero when otherwise not specified in period input data and the auxiliary parameter is not controlled by a time-series.
 	%	\item xxx
 	%	\item xxx
 	\end{itemize}

src/Utilities/Idm/mf6blockfile/StressGridInput.f90

@@ -234,8 +234,7 @@ subroutine ingrid_reset(this)
     use InputDefinitionModule, only: InputParamDefinitionType
     use DefinitionSelectModule, only: get_param_definition_type
     class(StressGridInputType), intent(inout) :: this !< StressGridInputType
-    type(InputParamDefinitionType), pointer :: idt
-    integer(I4B) :: n
+    integer(I4B) :: n, m
     !
     if (this%tas_active /= 0) then
       !
@@ -249,19 +248,22 @@ subroutine ingrid_reset(this)
                                   this%mf6_input%mempath, this%sourcename)
     end if
     !
-    ! -- reset input context memory for parameters
     do n = 1, this%nparam
       if (this%param_reads(n)%invar /= 0) then
-        !
-        ! -- set definition
-        idt => this%mf6_input%param_dfns(this%idt_idxs(n))
         !
         ! -- reset read state
         this%param_reads(n)%invar = 0
-
+        !
       end if
     end do
     !
+    ! -- explicitly reset auxvar array each period
+    do m = 1, this%bndctx%ncpl
+      do n = 1, this%bndctx%naux
+        this%bndctx%auxvar(n, m) = DZERO
+      end do
+    end do
+    !
     ! -- return
     return
   end subroutine ingrid_reset