From 2996ac0054ef441c8e68925eadc7e53086ef1c8f Mon Sep 17 00:00:00 2001
From: mjr-deltares <45555666+mjr-deltares@users.noreply.github.com>
Date: Fri, 26 Jan 2024 22:36:47 +0100
Subject: [PATCH] fix IDM loading of exchanges (#1577)

---
 src/Utilities/Idm/IdmLoad.f90 | 30 +++++++++++++++++++++++-------
 1 file changed, 23 insertions(+), 7 deletions(-)

diff --git a/src/Utilities/Idm/IdmLoad.f90 b/src/Utilities/Idm/IdmLoad.f90
index 9e98e4c92b0..b7c95f238dd 100644
--- a/src/Utilities/Idm/IdmLoad.f90
+++ b/src/Utilities/Idm/IdmLoad.f90
@@ -269,7 +269,8 @@ end subroutine load_models
   subroutine load_exchanges(model_loadmask, iout)
     ! -- modules
     use MemoryHelperModule, only: create_mem_path
-    use MemoryManagerModule, only: mem_setptr, mem_allocate, mem_deallocate
+    use MemoryManagerModule, only: mem_setptr, mem_allocate, &
+                                   mem_deallocate, get_isize
     use CharacterStringModule, only: CharacterStringType
     use SimVariablesModule, only: idm_context, simfile
     use SourceCommonModule, only: idm_subcomponent_type, ifind_charstr
@@ -301,7 +302,7 @@ subroutine load_exchanges(model_loadmask, iout)
     character(len=LENCOMPONENTNAME) :: sc_type, sc_name, mtype
     class(StaticPkgLoadBaseType), pointer :: static_loader
     class(DynamicPkgLoadBaseType), pointer :: dynamic_loader
-    integer(I4B) :: n, m1_idx, m2_idx, irem
+    integer(I4B) :: n, m1_idx, m2_idx, irem, isize
     !
     ! -- set input memory path
     input_mempath = create_mem_path('SIM', 'NAM', idm_context)
@@ -360,8 +361,13 @@ subroutine load_exchanges(model_loadmask, iout)
           mfname = mfnames(irem)
           mname = mnames(irem)
           mempath = create_mem_path(component=mname, context=idm_context)
-          call mem_allocate(ncelldim, 'NCELLDIM', mempath)
-          ncelldim = remote_model_ndim(mtype, mfname)
+          call get_isize('NCELLDIM', mempath, isize)
+          if (isize < 0) then
+            call mem_allocate(ncelldim, 'NCELLDIM', mempath)
+            ncelldim = remote_model_ndim(mtype, mfname)
+          else
+            call mem_setptr(ncelldim, 'NCELLDIM', mempath)
+          end if
         else
           nullify (ncelldim)
         end if
@@ -393,13 +399,23 @@ subroutine load_exchanges(model_loadmask, iout)
           deallocate (static_loader)
         end if
         !
-        ! -- deallocate ncelldim as all input has been loaded
-        if (associated(ncelldim)) call mem_deallocate(ncelldim)
-        !
       end if
       !
     end do
     !
+    ! -- clean up temporary NCELLDIM for remote models
+    do n = 1, size(mnames)
+      if (model_loadmask(n) == 0) then
+        mname = mnames(n)
+        mempath = create_mem_path(component=mname, context=idm_context)
+        call get_isize('NCELLDIM', mempath, isize)
+        if (isize > 0) then
+          call mem_setptr(ncelldim, 'NCELLDIM', mempath)
+          call mem_deallocate(ncelldim)
+        end if
+      end if
+    end do
+    !
     ! -- return
     return
   end subroutine load_exchanges