Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfct(solution): encapsulate convergence params #1353

Merged
merged 31 commits into from
Sep 29, 2023

Conversation

mjr-deltares
Copy link
Contributor

@mjr-deltares mjr-deltares commented Sep 18, 2023

There are a multiple smaller issues in here related to Numerical Solution and Convergence:

  • dv change and residual change per model, per iteration now available for PETSc
  • IMS parameters are passed into PETSc, the .petscrc file is now optional
  • A skeleton was added for a (PCSHELL) custom preconditioner in PETSc (which now holds an example Jacobi PC)
  • Cleaned up PETSc convergence module with explicit interface for the KSPSetConvergenceTest function
  • (small work in progress: the newtonur test doesn't converge on the CI without the petscrc file)

- dirichlet adjustments not yet for parallel
- print pc sub type
# Conflicts:
#	make/makefile
# Conflicts:
#	make/makefile
@jdhughes-dev jdhughes-dev merged commit 0e76846 into MODFLOW-ORG:develop Sep 29, 2023
@mjr-deltares mjr-deltares deleted the rfct-numsol branch October 2, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants