refactor(IC): integrate initial conditions pkg with IDM #1425
Conversation
wpbonelli
commented
Nov 3, 2023
•
wpbonelli
commented
- use IDM to load flow and transport model initial conditions (no options, just grid data)
- rebased after refactor(idm): remove component level FoundType and param sfac constr… #1421
| ! -- ensure STRT was found | ||
| if (.not. found%strt) then | ||
| write (errmsg, '(a)') 'Error in GRIDDATA block: STRT not found.' | ||
| call store_error(errmsg) |
There was a problem hiding this comment.
I think we need another call to say what input file caused this error. Also, if store_error() isn't given terminate=.true., in this case the program will just continue until we do a check for count_errors. Do we need something like this?
call store_error_filename(this%input_fname)
There was a problem hiding this comment.
Revised to
call store_error(errmsg, terminate=.false.)
call store_error_filename(this%input_fname)
I noticed store_error defaults to terminate false while store_error_filename defaults true. Should these be consistent or is this deliberate?
src/Model/GroundWaterFlow/gwf3.f90
Outdated
| ! -- Allocate and read modules attached to model | ||
| if (this%inic > 0) call this%ic%ic_ar(this%x) | ||
| ! -- Load modules attached to model | ||
| if (this%inic > 0) call this%ic%ic_load(this%x) |
There was a problem hiding this comment.
Unless there is some reason we need to wait until AR, I think we should call this ic_load method as soon as possible, maybe toward the end of ic_create?
There was a problem hiding this comment.
After trying this out, it seems this needs to come after define (*_df), I think because that's where discretization sources its info, so I left this in AR for now.
| ! | ||
| ! -- Assign x equal to strt | ||
| ! -- assign starting head |
There was a problem hiding this comment.
Maybe we couldn't do this in ic_cr, which is why we are calling ic_load() as part of the AR calls. Maybe we can keep an ic_ar() routine and assign strt to model%x in it. I know it is not a "allocate and read" action, but maybe we keep the names consistent for now and consider renaming them later.
There was a problem hiding this comment.
