Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filtering results by p-value returns combos with p-values greater than parameter value instead of less than #15

Open
mjsduncan opened this issue Apr 23, 2019 · 1 comment
Open

filtering results by p-value returns combos with p-values greater than parameter value instead of less than #15

mjsduncan opened this issue Apr 23, 2019 · 1 comment

Comments

@mjsduncan
Copy link
Contributor

so this filters out all the models we want instead of the models we don't want.
@Habush
Copy link
Collaborator

Habush commented Apr 23, 2019

Should this be also the case for overfitness filter? i.e should it return models whose difference between train and test pvalue scores is less than the threshold?

Habush added a commit that referenced this issue Apr 23, 2019
@Habush
p-value score filtering must returns results less than the threshold #15
33684a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjsduncan @Habush