Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the page-message handling #33

Open
helkv opened this issue Jun 21, 2018 · 0 comments
Open

Refactor the page-message handling #33

helkv opened this issue Jun 21, 2018 · 0 comments

Comments

@helkv
Copy link

helkv commented Jun 21, 2018

Page-messages display the success or the failure of many actions. Because they cover other elements for some time, they must be handled correctly in the test-methods.

Actual Approach:

  • to avoid ElementClickIntercepted-failures, the messages are hidden, when they cover other elements that will be clicked
  • the hideMessages() method hides the message, by setting the display style to none (Handle test failures caused by message area #31)

Problems:

  • sometimes it is not obvious why the hideMessages() method is called (e.g. at the end of a test, when the message would cover elements to be clicked in the following test)
  • the hideMessages() method is called very often inside test-methods, which unnecessary enlarges the test-methods

TODO:

  • use a more generic approach
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant