Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GC Statistics and time measuring #67

Closed
ramLlama opened this issue Oct 12, 2017 · 3 comments
Closed

Fix GC Statistics and time measuring #67

ramLlama opened this issue Oct 12, 2017 · 3 comments
Assignees

Comments

@ramLlama
Copy link
Collaborator

getrusage(RUSAGE_THREAD, ...) is too low precision to get accurate GC times.

@ramLlama
Copy link
Collaborator Author

So, I can calculate the wallclock time taken by GC using clock_gettime(), but I no longer have the user/sys split that rusage has. As such, these timings don't really fit into the GC rusage. Any thoughts on this?

A couple options:

  • keep both -- The GC rusage remains, but is imprecise (perhaps to the point of being useless). Add additional MLton.GC.Statistics functions that return time taken.
  • fold the result from clock_gettime() into the rusage, perhaps as the user field. This is most transparent since the API remains unchanged, but the rusage data is now wrong, since all GC time will be in the user slot.

@shwestrick shwestrick changed the title Fix GC time measuring Fix GC Statistics and time measuring Dec 6, 2019
@shwestrick
Copy link
Collaborator

We also need to update MLton.GC.Statistics for the new algorithms. What is a reasonable interface?

@shwestrick
Copy link
Collaborator

Closing this issue, as it is subsumed by #106.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants