Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReferenceError with Buffer object for iOS #38

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix ReferenceError with Buffer object for iOS #38

wants to merge 1 commit into from

Conversation

batman-nair
Copy link
Contributor

Use generic Uint8Array instead of the Buffer object. Buffer object raises a reference error and the base Uint8Array works well enough for the use case.
Tested locally. With the fix, I can view pdfs on my iPhone app.

Resolves #36 and #21

@sportluffi
Copy link

@MSzturc Can we do something to get this PR merged?

@joleaf
Copy link

joleaf commented Jun 15, 2023

@batman-nair & @sportluffi This PR is included in the Better PDF 2 plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReferenceError: Can't find variable: Buffer
3 participants
@batman-nair @sportluffi @joleaf