Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rankings Efficiency Discussion #1261

Open
farooqkz opened this issue Jan 8, 2024 · 3 comments
Open

Rankings Efficiency Discussion #1261

farooqkz opened this issue Jan 8, 2024 · 3 comments

Comments

@farooqkz
Copy link
Contributor

farooqkz commented Jan 8, 2024

The current structure storage of rankings using Redis is not efficient at all. IMO, we must be using either something like SQL or Redis sorted sets. Then we easily can get top N, and ranking of each user. I also suggest storing online/play time in the DB.

I am going to do it on the experimental server and then expose a RESTful rankings API. I've opened this issue to better track of the progress and receive comments and feedbacks.

@LoneWolfHT
Copy link
Member

If it doesn't have anything to do with rankings it shouldn't be in the rankings db.

Then we easily can get top N, and ranking of each user.

Are you suggesting sorted sets because they're easier, more efficient, or both? I've never heard of them until now, so I'll need to go and figure out what they are before I can approve switching to them.

@farooqkz
Copy link
Contributor Author

farooqkz commented Jul 3, 2024

For other's information, approval of switching to them has been given in Discord.

@LoneWolfHT LoneWolfHT changed the title Restructure the storage of rankings Rankings Efficiency Discussion Nov 21, 2024
@LoneWolfHT
Copy link
Member

Going to hijack this issue's topic a little so it applies to all ranking-related speed issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants