[Signalement] Enregistrement de l'identifiant BAN #3345
+198
−116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
numew
reviewed
Nov 27, 2024
emilschn
force-pushed
the
feature/3322-command-init-ban-id
branch
from
5f3b25f
to
1c2f1cb
Compare
numew
reviewed
Nov 28, 2024
| @@ -330,6 +334,21 @@ private function setAddressData(): void | |||
| ) | |||
| ->setAdresseAutreOccupant($this->signalementDraftRequest->getAdresseLogementComplementAdresseAutre()) | |||
| ->setManualAddressOccupant($this->signalementDraftRequest->getAdresseLogementAdresseDetailManual()); | |||
|
|
|||
| // Update geoloc and BAN ID if manual edit | |||
| if ($this->signalement->getManualAddressOccupant()) { | |||
There was a problem hiding this comment.
je comprends l'idée mais à mon avis on pourrais le faire dans tous les cas
There was a problem hiding this comment.
Oui ok
Pour la geoloc, ça me semble secondaire (on est forcé de le faire en front), mais pour l'ID BAN, il faut le faire de toute façon, et du coup, je le dégage de la partie front parce que c'est de la donnée trimballée inutilement
emilschn
commented
Nov 28, 2024
| @@ -88,7 +88,7 @@ export function attacheAutocompleteAddressEvent (inputAdresse) { | |||
| addressGroup.innerHTML = '' | |||
| selectionIndex = -1 | |||
| } | |||
|
|
|||
emilschn
commented
Nov 28, 2024
| const buttonElement = document.getElementById('tabpanel-'+currentHash) | ||
| const tabElement = document.getElementById('tabpanel-'+currentHash+'-panel'); | ||
| if(buttonElement && tabElement){ | ||
| const currentHash = window.location.hash !== '' ? window.location.hash.substring(1) : '' |
emilschn
force-pushed
the
feature/3322-command-init-ban-id
branch
from
98b41a9
to
4efef2a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#3322
Description
Afin de mieux s'interfacer avec d'autres SI, on enregistre l'identifiant retourné par la BAN qui correspond à un regroupement entre le code INSEE de la commune, un code pour la voie, et le numéro sur la voie.
Changements apportés
Pré-requis
npm run watchmake composermake execute-migration name=Version20241125151642 direction=upTests
make console app="init-id-ban"