Skip to content

Commit

Permalink
Tech - Ajout des domaines sans proxy (UPDATE ENV VAR) (#3888)
Browse files Browse the repository at this point in the history
## Linked issues

```
- MONITORFISH_HTTP_NON_PROXY_HOSTS=$MONITORFISH_HTTP_NON_PROXY_HOSTS
```

----

- [ ] Tests E2E (Cypress)
  • Loading branch information
louptheron authored Nov 25, 2024
2 parents e462031 + 393c637 commit 810d022
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
5 changes: 3 additions & 2 deletions infra/docker/app/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ USER monitorfish

ENTRYPOINT ["/home/monitorfish/env.sh"]

CMD exec java -Dhttp.proxyHost=${MONITORFISH_HTTP_HOST} -Dhttp.proxyPort=${MONITORFISH_HTTP_PORT} \
-Dhttps.proxyHost=${MONITORFISH_HTTP_HOST} -Dhttps.proxyPort=${MONITORFISH_HTTP_PORT} \
CMD exec java -Dhttp.proxyHost=${MONITORFISH_HTTP_PROXY_HOST} -Dhttp.proxyPort=${MONITORFISH_HTTP_PROXY_PORT} \

Check warning on line 126 in infra/docker/app/Dockerfile

View workflow job for this annotation

GitHub Actions / Build and package

JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals

JSONArgsRecommended: JSON arguments recommended for CMD to prevent unintended behavior related to OS signals More info: https://docs.docker.com/go/dockerfile/rule/json-args-recommended/
-Dhttps.proxyHost=${MONITORFISH_HTTP_PROXY_HOST} -Dhttps.proxyPort=${MONITORFISH_HTTP_PROXY_PORT} \
-Dhttp.nonProxyHosts=${MONITORFISH_HTTP_NON_PROXY_HOSTS} -Dhttps.nonProxyHosts=${MONITORFISH_HTTP_NON_PROXY_HOSTS} \
-Dspring.config.additional-location="/home/monitorfish/configurations/" \
-jar "monitorfish-${VERSION}.jar"
5 changes: 3 additions & 2 deletions infra/remote/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ services:
environment:
- SPRING_PROFILES_ACTIVE=$MONITORFISH_ENV
- HOST_IP=127.0.0.1
- MONITORFISH_HTTP_HOST=$MONITORFISH_HTTP_HOST
- MONITORFISH_HTTP_PORT=$MONITORFISH_HTTP_PORT
- MONITORFISH_HTTP_PROXY_HOST=$MONITORFISH_HTTP_PROXY_HOST
- MONITORFISH_HTTP_PROXY_PORT=$MONITORFISH_HTTP_PROXY_PORT
- MONITORFISH_HTTP_NON_PROXY_HOSTS=$MONITORFISH_HTTP_NON_PROXY_HOSTS
- ENV_DB_URL=jdbc:postgresql://db:5432/$POSTGRES_DB?user=$POSTGRES_USER&password=$POSTGRES_PASSWORD
- FRONTEND_GEOSERVER_REMOTE_URL=$MONITORFISH_GEOSERVER_REMOTE_URL
- FRONTEND_GEOSERVER_LOCAL_URL=$MONITORFISH_GEOSERVER_LOCAL_URL
Expand Down

0 comments on commit 810d022

Please sign in to comment.