[tra-15096][tra-14783] - Refacto de la fonction canReviewBsd
#3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitguigal
changed the title
canReviewBsd
benoitguigal
force-pushed
the
tra-15096
branch
4 times, most recently
from
76ec45b to
570a866
Compare
Concerne un fichier de test, bizarre que SonarCloud râle |
GaelFerrand
approved these changes
Nov 28, 2024
…ker, and intermediaries should not be able to revise a BSDD
benoitguigal
force-pushed
the
tra-15096
branch
from
570a866 to
b641b25
Compare
|
Riron
approved these changes
Nov 29, 2024
providenz
approved these changes
Dec 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deux bugs corrigés ici par le refacto de la fonction
canReviewBsdd:Les fonctions
canReviewBsdd,canReviewBsdaetcanReviewBsdasiétaient devenus de vrais sacs de noeuds, je suis reparti des specs et j'ai ajouté des tests pour chaque use casehttps://docs.google.com/spreadsheets/d/1Mp2Q2Esn3jFa3RT1NtW7WAYq0vh9-iv-xoppEoW80Hk/edit?gid=2124745641#gid=2124745641
Démo - les négociants, courtiers et intermédiaires n'ont pas accès à la révision
Enregistrement.de.l.ecran.2024-12-06.a.09.15.59.mov
Démo - Retirer la possibilité de réviser une annexe 1 avant la signature transport pour tous les acteurs
Enregistrement.de.l.ecran.2024-12-06.a.09.21.50.mov