Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor to acutally use DYNAMIC_LIST #181

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

mattip
Copy link
Collaborator

@mattip mattip commented Aug 11, 2024

  • I updated the version in pyproject.toml and made sure it matches git describe --tags --abbrev=8 in OpenBLAS at the OPENBLAS_COMMIT

  • don't redirect, add QUIET_MAKE to see if travis log file is still too big

  • move some variables around

Trying this out locally, it seems I should see -DDYN_PRESCOTT -DDYN_NEHALEM -DDYN_SANDYBRIDGE -DDYN_HASWELL -DDYN_SKYLAKEX in the cc command line in the logs

echo done building, now testing
make BUFFERSIZE=20 DYNAMIC_ARCH=1 \
USE_OPENMP=0 NUM_THREADS=64 \
BINARY=$bitness $interface_flags $target_flags tests
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may have been the problem. I did it to break up the build and try to get some log files, since on TravisCI there is a hard limit on the size of the logs. But make test requires make shared, and the command here was without the DYNAMIC_LIST. So make rebuilt all the kernels :(.

@mattip
Copy link
Collaborator Author

mattip commented Aug 11, 2024

Comfirmed this time, the manylinux_x86_64 wheels have a 21MB shared object instead of a 35MB one.

@mattip mattip merged commit e1efeba into MacPython:maintenance/v0.3.27.44 Aug 11, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant