Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magento.salesOrderShipment.list with filters does not work #14

Open
ecuaryan opened this issue Oct 23, 2014 · 0 comments
Open

magento.salesOrderShipment.list with filters does not work #14

ecuaryan opened this issue Oct 23, 2014 · 0 comments

Comments

@ecuaryan
Copy link

https://github.com/MadisonReed/magentoapi/blob/master/readmes/sales_order_shipment.md --> the list method does not work correctly when filters are provided.

https://github.com/MadisonReed/magentoapi/blame/master/src/resources/sales_order_shipment.js --> we found that if we removed lines 62 - 71 that it fixed the problem

62 modifiers: {
63 filters: function(filters) {
64 // if filters is not an array, wrap it in an array
65 if (!Array.isArray(filters)) {
66 return [ filters ];
67 }
68
69 return filters;
70 }
71 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant