-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconstructed images: Linkage between measurement and reconstruction (and calibration)? #92
Comments
Since MDF is for exchange I would not rely on the directory structure. I think it would be much more convenient to use the |
@NeumannIMT: Where is this issue? (Measurement data should not be stored in a Reco file) |
you are right did not see that connection. (Missing explanation in spec?) Wait! Stepping back to get the bigger picture: Interessting. If /experiment/uuid is extra generated or just the file/uuid is in my opinion up to the implementer and another issue. (Won't raise this one; It could have some benefit in searching if experiment/uuid is in fact a file/uuid) ToDo: |
That is how we intended the UUIDs to be used. @NeumannIMT would be great if you update the MDF. |
@tknopp Sry to bother you again but the proposed solution does not work in all cases. Here is the case. If I store a raw measurement it has a fixed exp/uuid. If I then postprocess the data and create a new file out of it it has the same exp/uuid. A reconstruction using one of the files thus becomes ambiguous to which file has really been used. My solution:
Can do if we have a (working) solution. |
yes I understand. We actually store the path to the calibration file in a private Reco parameter. I am actually not so sure what we should do. A dependency group is IMHO not good. If, then lets put that in /reconstruction/. We use the folder solution, since it scales extremely well and we then always know what the actual measurement was. This solution does however not contains processings, which might be a problem. Not sure. For measurement data we (HH) will never store anything else but the most Raw step. For calibration data certainly not. So, difficult. |
And by the way, we do reconstructions, where several measurements are combined. We also use reconstructions, where several calibrations are involved. |
seems to be not general enough if we allow postprocessing on data or calibration files.
Why? From viewpoint it seems to be a more general solution.
|
I think at one point this issue is reaching a little bit too far. Most of the MDF users will not have a complete MDF infrastructure, but merely methods to convert from their respective data format to MDF. If so it is most likely that the dependencies will often be be non MDF files. Or even worse it could be that my system matrix is stored inside a MDF, but the measurements are not. What to do in such a case? Storing just the MDF part seems useless to me without the non MDF part. From this perspective I would question the why we need a to specify how to link measurements and reconstructions in the first place. If we have no specifications on this issue the user has the freedom to create his own solutions if he has the need to (like we do here in Hamburg). |
I am marking this post v2.0. Dependencies are an open issue but they are highly related to reconstruction parameters which we also do not specify in 2.0. The main focus now are how to store measurements and calibrations. |
MDF does not seem to specify how measurement and a reconstructed image are linked together. Since one measurement can be reconstructed multiple times copying the measurement into each reconstruction file seems inefficient. Although the linkage can be described by a directory structure (see #45) I would rather have an in file description for that (either use file uuid or somehow allow virtual linkage of the HDF5 measurement file [or both])
If the reconstruction is based on a systemmatrix or calibration the linkage to the systemmatrix/calibration must also be specified.
The text was updated successfully, but these errors were encountered: