Clean up attribute inheritance for theming #4196
jkrumbiegel
started this conversation in
Ideas
Replies: 1 comment
-
Can this be closed? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
With the new figure and the larger role of Axis types our old model fails in unexpected ways, so we should think about how to clean it up.
The premise should be that (almost) everything is themeable, every plot type, every Layoutable like Axis, Colorbar, etc.
Some places which involve attributes that we can manipulate are:
const
default minimal themeset_theme!
attributes
fieldBecause layoutables used to be put directly into a scene, they want to inherit possible attributes from that scene. This is still the case even with Figure. Actually, the keywords passed at creation of the figure are currently just forwarded to
fig.scene
and the layoutables grab them from there.Layoutables check for an entry with their own type name in the theme like
Axis = (xticks = ...
orColorbar...
.Plots had that behavior at some point but it doesn't seem to work anymore to theme
scatter
with a keyword in the theme. Something's broken there.Basically, we need to come up with some graph that describes how attributes flow from the top to the bottom. Any ideas?
Beta Was this translation helpful? Give feedback.
All reactions