Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scatterlines.inspector_label is broken #4713

Open
3 tasks done
Joroks opened this issue Jan 10, 2025 · 1 comment
Open
3 tasks done

scatterlines.inspector_label is broken #4713

Joroks opened this issue Jan 10, 2025 · 1 comment
Labels
bug DataInspector Makie Backend independent issues (Makie core)

Comments

@Joroks
Copy link

Joroks commented Jan 10, 2025

For the following example:

using GLMakie

fig = Figure()
ax = Axis(fig[1,1])

DataInspector(ax)

lines!(ax, [1, 2], [1, 2];
    inspector_label=Returns("This works")
)

scatter!(ax, [1, 2], [1.5, 2.5];
    inspector_label=Returns("This also works")
)

scatterlines!(ax, [1, 2], [2, 3];
    inspector_label=Returns("This doesn't work")
)

fig

only the lines and scatter plot show the correct label. However, the scatterlines plot shows the default label.

Image
Image
Image
Image

I'm on Makie v0.21.18 and julia v1.11.2 on Windows with an Nvidia GPU

  • what version of Makie are you running? (]st -m Makie)
  • can you reproduce the bug with a fresh environment ? (]activate --temp; add Makie)
  • What platform + GPU are you on?
@Joroks Joroks added the bug label Jan 10, 2025
@ffreyer ffreyer added Makie Backend independent issues (Makie core) DataInspector labels Jan 18, 2025
@ffreyer
Copy link
Collaborator

ffreyer commented Jan 18, 2025

Hmm, maybe it makes sense for child plots to inherit inspector_label. I think I originally didn't do that because a callback applicable to e.g. lines wouldn't work for e.g. mesh. But since the plot is part of the callback arguments you could just write multiple branches/methods.

Maybe something to add to #4399 / consider in #4630.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug DataInspector Makie Backend independent issues (Makie core)
Projects
None yet
Development

No branches or pull requests

2 participants