-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PolarAxis ticks #4773
Comments
Mirroring doesn't really make sense for a polar axis I think...flipping might but theta already has a similar thing, so it would just be for r |
Alignment is also weird on polar axes |
I'm probably missing something but doesn't mirroring make sense for r as long as theta does not wrap around the full 2pi and for theta as long as the lower limit for r is strictly positive? |
That's a good point, if the polar axis does not cover the full angular range then there's room for mirroring in r, and vice versa for theta. |
I wouldn't even know where to start, but what is challenging for |
Some of the things you listed should be easy to do - they just need to be added to the Block attributes in Makie.jl/src/makielayout/types.jl Line 1952 in de99964
Makie.jl/src/makielayout/blocks/polaraxis.jl Line 557 in de99964
Things like align and maybe mirroring could get more tricky because PolarAxis adjusts align and offset based where the tick label is placed. All of that should also be contained in the draw_axis function though |
For theta ticks, for example, alignment is defined based on the angle the tick is at - similar for r ticks also I believe. If you don't do that, then the tick will probably clip into the axis at some angle. |
I understand that, but I think those angles are already computed here to place the labels, right? I'm just not sure where this happens, and I'm also lost as to where and what the code for drawing the ticks should be. |
Feature description
I would like to kindly request an option to display ticks in a
PolarAxis
. I am assuming ideally thatrticks
andthetaticks
would be controlled through the same options as forxticks
, that is through these kwargs:(FWIW I'm coming from #4771 requesting a recipe for Taylor diagrams.)
The text was updated successfully, but these errors were encountered: