Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typings for BankingAliases.getAll #351

Open
Tug opened this issue Mar 8, 2023 · 1 comment
Open

Update typings for BankingAliases.getAll #351

Tug opened this issue Mar 8, 2023 · 1 comment

Comments

@Tug
Copy link

Tug commented Mar 8, 2023

Seems like types for this method signature are not up to date:

https://github.com/Mangopay/mangopay2-nodejs-sdk/blob/master/typings/services/BankingAliases.d.ts#L27

Should be something like: MethodOverload<string, bankingAlias.IBANBankingAliasData[]> I believe. That string param type is the walletId according to the documentation at https://docs.mangopay.com/endpoints/v2.01/banking-aliases#e858_view-the-banking-alias-for-a-wallet

@david-kovacs-techmates
Copy link

david-kovacs-techmates commented Nov 9, 2023

I am running into the same issue currently. Applying the fix @Tug suggested locally inside node_modules fixes the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants