Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning Code #30

Open
naveen521kk opened this issue Feb 27, 2021 · 3 comments
Open

Cleaning Code #30

naveen521kk opened this issue Feb 27, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
v1.0.0

Comments

@naveen521kk
Copy link
Member

There is a significant copy-pasting of the same code, for Text and MarkupText, instead if needs to be cleaned up so it is more maintainable.
@naveen521kk naveen521kk mentioned this issue Feb 28, 2021
Open
@PhilippImhof
Copy link
Member

I suggest having some sort of AbstractText class containing all common parts (where it is sensible) and then have Text and MarkupText as extensions of AbstractClass.

@naveen521kk naveen521kk mentioned this issue Mar 1, 2021
Closed
@naveen521kk naveen521kk added enhancement New feature or request help wanted Extra attention is needed labels Mar 1, 2021
@naveen521kk
Copy link
Member Author

@PhilippImhof are you interested in doing this?

@PhilippImhof
Copy link
Member

Yes, absolutely. I will draft a concept and discuss it with you before I start coding. But I need some time...

@naveen521kk naveen521kk added this to the v1.0.0 milestone Mar 30, 2021
@naveen521kk naveen521kk mentioned this issue May 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Stable API ManimCommunity/ManimPango
2 participants
@naveen521kk @PhilippImhof