Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Pyav for Handling Ffmpeg #442

Closed
naveen521kk opened this issue Sep 14, 2020 · 5 comments · Fixed by #3501
Closed

Using Pyav for Handling Ffmpeg #442

naveen521kk opened this issue Sep 14, 2020 · 5 comments · Fixed by #3501
Labels
enhancement Additions and improvements in general help wanted We would appreciate help on this issue/PR

Comments

@naveen521kk
Copy link
Member

Currently, AFAIK, Manim calls Ffmpeg using subprocess, which is very slow. In a plan to making manim more faster we can use a Python Ffmpeg wraper, like Pyav which is written in C and is a lot faster than directly calling using subprocess and also more Pythonic. I think doing this would just need to edit a file scene_writer.py. Also, this would mean that we wouldn't need to ask users to install Ffmpeg as it would be included in PyAv.

Refs

Pyav Documentation: https://pyav.org/docs/stable/index.html
Pyav Project Source: https://github.com/PyAV-Org/PyAV

@leotrs
Copy link
Contributor

leotrs commented Sep 14, 2020

Interesting suggestion - I'm generally in favor of this, though I would hesitate to make the change entirely without first having a more robust test suite.

Also, instead of replacing the current file writer to use PyAV, we could implement a new one, FileWriterAV that uses this but keep using the ffmpeg one as default until FileWriterAV is stable.

@naveen521kk
Copy link
Member Author

Yeah, @leotrs What you told is good. Let's work on a new class and making it optional.(using config system). But later making it default depreciating the previous one.

@nilaybhatia nilaybhatia added the enhancement Additions and improvements in general label Sep 15, 2020
@huguesdevimeux
Copy link
Member

Very intersting idea. Could you PR on this . (if yes, please assign yourself on this issue :D)

@naveen521kk
Copy link
Member Author

I think I wouldn't be time to work on this. The issue is open for anyone.

@naveen521kk naveen521kk added hacktoberfest help wanted We would appreciate help on this issue/PR labels Sep 28, 2020
@kolibril13
Copy link
Member

Any updates here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additions and improvements in general help wanted We would appreciate help on this issue/PR
Projects
Status: 🆕 New
6 participants