From fd2192c513f95afbfe77808ce8eccf8407162f64 Mon Sep 17 00:00:00 2001 From: zoya5636 Date: Thu, 28 Nov 2024 15:53:40 -0500 Subject: [PATCH 1/3] fix: default_numbers_to_display function was not implemented --- manim/mobject/graphing/number_line.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/manim/mobject/graphing/number_line.py b/manim/mobject/graphing/number_line.py index efb95ae399..2a81ccf4b7 100644 --- a/manim/mobject/graphing/number_line.py +++ b/manim/mobject/graphing/number_line.py @@ -484,6 +484,18 @@ def get_number_mobject( # Align without the minus sign num_mob.shift(num_mob[0].width * LEFT / 2) return num_mob + + def default_numbers_to_display(self): + leftmost_tick = op.mul( + self.tick_frequency, np.ceil(self.x_min / self.tick_size) + ) + numbers = np.arange( + np.floor(self.leftmost_tick), + np.ceil(self.x_max), + ) + if self.exclude_zero_from_default_numbers: + numbers = numbers[numbers != 0] + return numbers def get_number_mobjects(self, *numbers, **kwargs) -> VGroup: if len(numbers) == 0: From 06f531385f4a86c5f2fa5e8acb6ee07e8e636ec5 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu, 28 Nov 2024 22:31:42 +0000 Subject: [PATCH 2/3] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- manim/mobject/graphing/number_line.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manim/mobject/graphing/number_line.py b/manim/mobject/graphing/number_line.py index 2a81ccf4b7..37fcfb8c7a 100644 --- a/manim/mobject/graphing/number_line.py +++ b/manim/mobject/graphing/number_line.py @@ -484,7 +484,7 @@ def get_number_mobject( # Align without the minus sign num_mob.shift(num_mob[0].width * LEFT / 2) return num_mob - + def default_numbers_to_display(self): leftmost_tick = op.mul( self.tick_frequency, np.ceil(self.x_min / self.tick_size) From 5f911f6dc9fefa12821c974479df645bedaeaa7e Mon Sep 17 00:00:00 2001 From: zoya5636 <83867635+zoya5636@users.noreply.github.com> Date: Thu, 28 Nov 2024 17:47:33 -0500 Subject: [PATCH 3/3] fixed variable being used --- manim/mobject/graphing/number_line.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/manim/mobject/graphing/number_line.py b/manim/mobject/graphing/number_line.py index 37fcfb8c7a..8db9462d47 100644 --- a/manim/mobject/graphing/number_line.py +++ b/manim/mobject/graphing/number_line.py @@ -490,7 +490,7 @@ def default_numbers_to_display(self): self.tick_frequency, np.ceil(self.x_min / self.tick_size) ) numbers = np.arange( - np.floor(self.leftmost_tick), + np.floor(leftmost_tick), np.ceil(self.x_max), ) if self.exclude_zero_from_default_numbers: