Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for new release workflow #206

Merged
merged 36 commits into from
Sep 12, 2024

Conversation

mschwoer
Copy link
Contributor

@mschwoer mschwoer commented Aug 23, 2024

Adapt the code to use the new shared release workflow (cf. here: MannLabs/alphashared#4)

Most changes are for the create_release workflow (https://github.com/MannLabs/alphapeptdeep/blob/main/.github/workflows/create_release.yml) and are around unifying the structure to match the expectations of the shared workflow.

Changes to legacy files and workflows (marked with a TODO to remove) are just to preserve their functionality until they are deleted.

For incorporating
https://github.com/MannLabs/alphapeptdeep/blob/main/.github/workflows/publish_on_pypi.yml no functional changes were required.

Tested:
https://github.com/MannLabs/alphapeptdeep/actions/runs/10578920267 =>
installers created: https://github.com/MannLabs/alphapeptdeep/releases/tag/untagged-7d1a181db6374a3587eb

https://github.com/MannLabs/alphapeptdeep/actions/runs/10576907112 => publishing failed due to same artifact already being on pypi, but should be fine

@mschwoer mschwoer requested a review from jalew188 August 27, 2024 13:41
@mschwoer mschwoer requested a review from GeorgWa August 27, 2024 13:41
@mschwoer mschwoer marked this pull request as ready for review August 27, 2024 13:48
@jalew188 jalew188 merged commit f29adc4 into development Sep 12, 2024
2 checks passed
@jalew188 jalew188 deleted the prepare-for-new-release-workflow branch September 12, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants