-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for new release workflow #206
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt the code to use the new shared release workflow (cf. here: MannLabs/alphashared#4)
Most changes are for the
create_release
workflow (https://github.com/MannLabs/alphapeptdeep/blob/main/.github/workflows/create_release.yml) and are around unifying the structure to match the expectations of the shared workflow.Changes to legacy files and workflows (marked with a
TODO
to remove) are just to preserve their functionality until they are deleted.For incorporating
https://github.com/MannLabs/alphapeptdeep/blob/main/.github/workflows/publish_on_pypi.yml no functional changes were required.
Tested:
https://github.com/MannLabs/alphapeptdeep/actions/runs/10578920267 =>
installers created: https://github.com/MannLabs/alphapeptdeep/releases/tag/untagged-7d1a181db6374a3587eb
https://github.com/MannLabs/alphapeptdeep/actions/runs/10576907112 => publishing failed due to same artifact already being on pypi, but should be fine