You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On windows 10 (using chrome browser) the windows_os_version is not correct.
It returns 'Generic windows'.
The reason is an overlapping in the regular expression for windows 10 and windows NT 4:
"WINDOWS_10": /(windows nt 10.0)/
"WINDOWS_NT_4_0": /(windows nt 4.0|winnt4.0|winnt|windows nt)/
Having a useragent-string "mozilla/5.0 (windows nt 10.0; win64; x64) applewebkit/537.36 (khtml, like gecko) chrome/72.0.3626.121 safari/537.36" both the windows10-regexp as winNt4-regexp passes test.
Is can easily be solved by just adjusting the order in the REG_WINDOWS_OS_VERSION constant in reg-expressions.constants.ts to follow the windows version history. If windows 10 is matched after windows 4 NT the windows_os_version will return the correct version.
Alternatively you could also try to have a more specific regexp but as I am not a expert (is anyone?) it can not make any concrete suggestion.
The text was updated successfully, but these errors were encountered:
On windows 10 (using chrome browser) the windows_os_version is not correct.
It returns 'Generic windows'.
The reason is an overlapping in the regular expression for windows 10 and windows NT 4:
"WINDOWS_10": /(windows nt 10.0)/
"WINDOWS_NT_4_0": /(windows nt 4.0|winnt4.0|winnt|windows nt)/
Having a useragent-string "mozilla/5.0 (windows nt 10.0; win64; x64) applewebkit/537.36 (khtml, like gecko) chrome/72.0.3626.121 safari/537.36" both the windows10-regexp as winNt4-regexp passes test.
Is can easily be solved by just adjusting the order in the REG_WINDOWS_OS_VERSION constant in reg-expressions.constants.ts to follow the windows version history. If windows 10 is matched after windows 4 NT the windows_os_version will return the correct version.
Alternatively you could also try to have a more specific regexp but as I am not a expert (is anyone?) it can not make any concrete suggestion.
The text was updated successfully, but these errors were encountered: