Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass JSON instead of string #33

Closed
worksofliam opened this issue Aug 30, 2024 · 0 comments · Fixed by #34
Closed

Pass JSON instead of string #33

worksofliam opened this issue Aug 30, 2024 · 0 comments · Fixed by #34

Comments

@worksofliam
Copy link
Collaborator

mapepire-js/src/sqlJob.ts

Line 116 in d8f276e

this.responseEmitter.emit(response.id, asString);

Do we really need to pass asString into the emitter and then re-parse it again in the handlers?
@worksofliam worksofliam linked a pull request Sep 3, 2024 that will close this issue
Fix/json_passing #34
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/json_passing Mapepire-IBMi/mapepire-js
1 participant
@worksofliam