Don't use sets we want to count

MarcusWolschon · Oct 31, 2024 · ef2c760 · ef2c760
1 parent 55b7dfd
commit ef2c760
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/main/java/de/blau/android/listener/UploadListener.java b/src/main/java/de/blau/android/listener/UploadListener.java
@@ -3,12 +3,10 @@
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.HashMap;
-import java.util.HashSet;
 import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
-import java.util.Set;
 import java.util.SortedMap;
 
 import android.content.DialogInterface;
@@ -161,8 +159,8 @@ private void upload() {
     private Map<String, String> generateAutoSummary(@NonNull List<OsmElement> elements) {
         List<String> created = new ArrayList<>();
         List<String> modified = new ArrayList<>();
-        Set<String> geometryModified = new HashSet<>();
-        Set<String> membersModified = new HashSet<>();
+        List<String> geometryModified = new ArrayList<>();
+        List<String> membersModified = new ArrayList<>();
         List<String> deleted = new ArrayList<>();
         Map<String, String> result = new HashMap<>();
         UndoStorage undoStorage = App.getDelegator().getUndo();
@@ -230,7 +228,7 @@ private Map<String, String> generateAutoSummary(@NonNull List<OsmElement> elemen
      * @param node the Node
      * @param geometryModified set of actions to return
      */
-    private void addModifiedWays(@NonNull Preset[] presets, @NonNull Node node, @NonNull Set<String> geometryModified) {
+    private void addModifiedWays(@NonNull Preset[] presets, @NonNull Node node, @NonNull Collection<String> geometryModified) {
         for (Way w : App.getLogic().getWaysForNode(node)) {
             PresetItem match = Preset.findBestMatch(caller, presets, w.getTags(), null, null, true);
             geometryModified.add(getPresetName(match));

diff --git a/src/main/res/values/strings.xml b/src/main/res/values/strings.xml
@@ -189,7 +189,7 @@
     <string name="untagged_relation">untagged relation</string>
     <string name="changed_preset">%1$s to %2$s</string>
     <string name="changed_tags">%1$s changed tags</string>
-    <string name="moved">moved %1$s</string>
+    <string name="moved">%1$s moved</string>
     <string name="unknown_object">unknown object</string>
     <!-- Review changes dialog -->
     <string name="review_changes_title">Review changes</string>