Scale rubric criterion levels on max_mark update #7311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavrao145
force-pushed
the
fix/rubric-criterion-denominator
branch
from
ad5c103 to
83c2862
Compare
Pull Request Test Coverage Report for Build 12076714915Details
💛 - Coveralls |
There was a problem hiding this comment.
@pranavrao145 thanks for doing this. I realized now why the code was written the way it was originally, as we didn't want to accidentally override the instructor's inputs on the form (for example, if the instructor changes the criterion max mark and the level weights at the same time).
This is a bit more work, but can you please modify the back-end algorithm so that
- for each existing level, if the
levels_attributeshas a mark that is different from the current level mark, use the newlevels_attributesmark directly (no scaling); but if thelevels_attributesmark is the same as the current level mark, scale that. - for each new level, use the instructor-provided mark in
levels_attributes(no scaling)
I think the easiest way to do this is to keep the original order of criterion/level updating, but prior to the level updating mutate the levels_attributes hash to compute the new level marks according to my above description.
pranavrao145
force-pushed
the
fix/rubric-criterion-denominator
branch
from
83c2862 to
5bd8e93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes #7296 by changing the order in which changes are processed when
max_markis updated on a rubric criterion.Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request: