-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fsspec requirement from ~=2024.12.0 to ~=2025.2.0 #88
Conversation
Updates the requirements on [fsspec](https://github.com/fsspec/filesystem_spec) to permit the latest version. - [Commits](fsspec/filesystem_spec@2024.12.0...2025.2.0) --- updated-dependencies: - dependency-name: fsspec dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes proposed in this commit are not likely to cause an issue. The only modified line ([10]) simply changes the version of fsspec
the software requires. However, we should be sure that the update won't cause any conflicts or dependency issues. Also, I would suggest confirming if fsspec~=2025.2.0
version exists or not as the version seems to be far ahead.
@@ -2,7 +2,7 @@ spacy~=3.8.3 | |||
ttkthemes~=3.2.2 | |||
pillow~=11.1.0 | |||
setuptools~=75.8.0 | |||
fsspec~=2024.12.0 | |||
fsspec~=2025.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure that the new fsspec
version you're updating to is compatible with the other package versions defined in this file especially if they were relying on the previous version 2024.12.0
. Also, please confirm if this version exists or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the code include a version update of a package in requirements.txt. The fsspec package version has been updated from 2024.12.0 to 2025.2.0. The change seems valid assuming that the new version is compatible with the rest of the project. It's important to conduct testing after such updates to make sure nothing broke.
@@ -2,7 +2,7 @@ spacy~=3.8.3 | |||
ttkthemes~=3.2.2 | |||
pillow~=11.1.0 | |||
setuptools~=75.8.0 | |||
fsspec~=2024.12.0 | |||
fsspec~=2025.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's good practice to provide a reason for updating the requirement version. Whether it contains bug fixes, new features or optimizations, it is good to document this in the commit message. This will help the team to understand the reasoning behind it and it will also help in case any issues occur later.
Updates the requirements on fsspec to permit the latest version.
Commits
f30bc75
changelog (#1786)7cc1644
referencefs: add streaming _open support (#1778)08d1e49
Cope with zarr3 Buffers in referenceFS (#1784)fe59f48
dropdask-expr
dependency from downstream tests (#1781)375a411
use codespell pre-commit hook (#1780)5163ac7
spec: fix spelling error in docstring for fs.walk (#1779)3763661
asyn_wrapper: avoid creating async version of open method (#1769)216885a
pre-commit autoupdate (#1774)30af5e1
Add newline inclusive disclaimer (#1770)1d34249
Use operator.itemgetter for perf/readability in archive (#1764)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)