Refactor usage of FocusManager to avoid weak table usage
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albyrock87
force-pushed
the
feature/2024-08-21-Windows-Use-FocusManager
branch
from
a70446c to
3d4b341
Compare
albyrock87
commented
Sep 9, 2024
albyrock87
force-pushed
the
feature/2024-08-21-Windows-Use-FocusManager
branch
from
3d4b341 to
14fd6af
Compare
MartyIX
force-pushed
the
feature/2024-08-21-Windows-Use-FocusManager
branch
from
68155a3 to
ab5551f
Compare
|
I guess I can close this because it has been cherry-picked. |
MartyIX
pushed a commit
that referenced
this pull request
Oct 30, 2024
…otnet#25178) * Enabling ported ui tests from Xamarin.UITests to appium * Build fixes * Update Bugzilla32040.cs * Update Bugzilla32148.cs * Removed unnecessary code * Update Bugzilla25662.cs * Update Bugzilla26171.cs * Update Bugzilla26501.cs * Update Bugzilla28001.cs * Update Bugzilla30317.cs * Update Bugzilla32462.cs * Update Bugzilla33870.cs * Some fixes * More changes * More changes * Simplified more tests * Fix build * Simplified tests * Fixed test * Added new project constants * More changes * More fixes --------- Co-authored-by: Shane Neuville <[email protected]>
MartyIX
pushed a commit
that referenced
this pull request
Nov 13, 2024
…otnet#25814) * Migrated the Issue2740 and ListViewNRE (#1) * Migrated the Issue2740 and ListViewNRE * Migrated the Issue1355 and Issue2923 * Feedback addressed --------- Co-authored-by: nivetha-nagalingam <[email protected]> * optimized the test code changes --------- Co-authored-by: nivetha-nagalingam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Besides avoid a potentially huge weak table, this solves the problem with UI test which was only due to
FocusManagerevents being triggered after view's focus events.